linux-kernel - Re: [PATCH 2/5] scsi: megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CAF40A0.5020506@redhat.com>
Date:	Fri, 08 Oct 2010 18:02:40 +0200
From:	Tomas Henzl <thenzl@...hat.com>
To:	"Yang, Bo" <Bo.Yang@....com>
CC:	James Bottomley <James.Bottomley@...e.de>,
	bo yang <boyang1288@...il.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"akpm@...l.org" <akpm@...l.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Daftardar, Jayant" <Jayant.Daftardar@....com>
Subject: Re: [PATCH 2/5] scsi: megaraid_sas - support devices update flag

On 10/08/2010 03:47 PM, Yang, Bo wrote:
> James,
>
> Thanks for getting the online controller reset in.  I downloaded patch 2/5 from  http://marc.info/?l=linux-scsi&m=128521127203199&w=2 and I can apply it without errors.
>
> Can you try it again?  otherwise I need to re-attach it.
>   
I've tried it (http://marc.info/?l=linux-scsi&m=128521127203199&w=2) and it is broken.
If you look at the end of the patche there should be 3 lines of the original code after 
the last + sign.

tomash

Broken:
+	driver_remove_file(&megasas_pci_driver.driver,
 			   &driver_attr_release_date);
 	driver_remove_file(&megasas_pci_driver.driver, &driver_attr_version);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Works for me:
+	driver_remove_file(&megasas_pci_driver.driver,
 			   &driver_attr_release_date);
 	driver_remove_file(&megasas_pci_driver.driver, &driver_attr_version);
 <- this line is missing in your patch
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in



> Thanks,
>
> Bo Yang    
>
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@...e.de] 
> Sent: Thursday, October 07, 2010 6:36 PM
> To: bo yang
> Cc: Yang, Bo; linux-scsi@...r.kernel.org; akpm@...l.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 2/5] scsi: megaraid_sas - support devices update flag
>
> On Wed, 2010-09-22 at 22:50 -0400, bo yang wrote:
>   
>> Driver added the Device update flag to tell LSI application driver
>> will do the device Update.  LSI MegaRAID SAS application will check
>> this flag to decide if it is need to update the Device or not.
>>     
> Well, the good news is I've got the Online Controller reset update. The
> bad news is that this patch now fails to apply: looks like an attachment
> problem again:
>
> Applying: megaraid_sas: support devices update flag
> fatal: corrupt patch at line 70
> Patch failed at 0001 megaraid_sas: support devices update flag
>
> James
>
>
> N�����r��y���b�X��ǧv�^�)޺{.n�+����{���"�{ay�.ʇڙ�,j.��f���h���z�.�w���.���j:+v���w�j�m����.����zZ+��ݢj"��!tml=

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/