linux-kernel - [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to retrieve the device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 8 Oct 2010 12:06:44 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	rusty@...tcorp.com.au
Cc:	Christoph Hellwig <hch@...radead.org>,
	Ryan Harper <ryanh@...ibm.com>, Tejun Heo <tj@...nel.org>,
	Mikulas Patocka <mpatocka@...hat.com>, dm-devel@...hat.com,
	Vivek Goyal <vgoyal@...hat.com>, john.cooper@...hat.com,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [2.6.36 REGRESSION] Re: virtio-blk: put request that was created to
 retrieve the device id

Hi Rusty,

On Tue, Sep 21 2010 at  5:00pm -0400,
Christoph Hellwig <hch@...radead.org> wrote:

> On Fri, Sep 17, 2010 at 09:58:48AM -0500, Ryan Harper wrote:
> > Since __bio_map_kern() sets up bio->bi_end_io = bio_map_kern_endio
> > (which does a bio_put(bio)) doesn't that ensure we don't leak?
> 
> Indeed, that should take care of it.
> 

We need to fix this regression for 2.6.36.  Not sure what else I need to
do to get this on your radar.  It's a pretty significant show-stopper
for 2.6.36 guests that use virtio-blk with a udev enabled distro.

Here is a reference to my original patch (which Ryan and hch have both
reviewed): https://patchwork.kernel.org/patch/165571/

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/