lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CB340F1.8020000@caviumnetworks.com>
Date:	Mon, 11 Oct 2010 09:53:05 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Bernhard Walle <walle@...science.de>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon: Add Lanai board USB clock type

On 10/11/2010 03:09 AM, Bernhard Walle wrote:
> Add the LANAI2 board to __cvmx_helper_board_usb_get_clock_type(). It
> also uses the USB_CLOCK_TYPE_CRYSTAL_12 clock.
>
> Signed-off-by: Bernhard Walle<walle@...science.de>
> ---
>   drivers/staging/octeon/cvmx-helper-board.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)

NAK.

We don't currently support USB, so churning up this file doesn't help 
anything.

If you are using an out-of-tree driver, you can keep this kind of tweak 
out-of-tree as well.

David Daney

>
> diff --git a/drivers/staging/octeon/cvmx-helper-board.c b/drivers/staging/octeon/cvmx-helper-board.c
> index 5793318..f8ae6b4 100644
> --- a/drivers/staging/octeon/cvmx-helper-board.c
> +++ b/drivers/staging/octeon/cvmx-helper-board.c
> @@ -752,6 +752,7 @@ cvmx_helper_board_usb_clock_types_t __cvmx_helper_board_usb_get_clock_type(void)
>   {
>   	switch (cvmx_sysinfo_get()->board_type) {
>   	case CVMX_BOARD_TYPE_BBGW_REF:
> +	case CVMX_BOARD_TYPE_LANAI2_G:
>   		return USB_CLOCK_TYPE_CRYSTAL_12;
>   	}
>   	return USB_CLOCK_TYPE_REF_48;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ