linux-kernel - Re: [PATCH] Define _addr_lsb in siginfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin7_3_iwn2xf=wy9ho9GfCHw+eSTjv12z1ESWr5@mail.gmail.com>
Date:	Mon, 11 Oct 2010 09:53:22 -0700
From:	Tony Luck <tony.luck@...il.com>
To:	Andi Kleen <andi@...stfloor.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>
Subject: Re: [PATCH] Define _addr_lsb in siginfo_t for mips and ia64

On Fri, Oct 8, 2010 at 11:13 AM, Luck, Tony <tony.luck@...el.com> wrote:
> ia64 has HAVE_ARCH_COPY_SIGINFO_TO_USER - so it doesn't see
> this build problem because the version of copy_siginfo_to_user()
> in kernel/signal.c isn't the one we use. So I don't think that
> we need this (unless someone has some plan to unify the
> ARCH specific version).

I take this back ... in next-20101011 the disease has spread:

fs/signalfd.c: In function ‘signalfd_copyinfo’:
fs/signalfd.c:109: error: ‘const struct <anonymous>’ has no member
named ‘_addr_lsb’
fs/signalfd.c:109: warning: type defaults to ‘int’ in declaration of ‘__pu_x’
fs/signalfd.c:109: error: ‘const struct <anonymous>’ has no member
named ‘_addr_lsb’

So today I have build problems :-(

A question about the naming/type of this new field. "lsb" sounds like
it might mean
"least significant byte (or perhaps bit)" ... why is the type "short"?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/