linux-kernel - [PATCH] [staging] brcm80211: fix radio disabled on attempt to bring up interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1286872198-10664-1-git-send-email-jcm@jonmasters.org>
Date:	Tue, 12 Oct 2010 04:29:58 -0400
From:	jcm@...masters.org
To:	linux-wireless@...r.kernel.org
Cc:	Brett Rudley <brudley@...adcom.com>,
	Henry Ptasinski <henryp@...adcom.com>,
	Nohee Ko <noheek@...adcom.com>,
	Jon Masters <jcm@...masters.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] [staging] brcm80211: fix radio disabled on attempt to bring up interface

The brcm80211 driver does not correctly handle the case that the wireless
radio hardware is physically disabled during interface initialization. An
attempt is made to check whether the radio is disabled, and in the case
that it is, a background worker is setup to monitor for the radio coming
online, but the interface queues are incorrectly brought up anyway. The
value BCME_RADIOOFF should be returned in wlc_up in such error case.

Signed-off-by: Jon Masters <jcm@...masters.org>

diff -urNp brcm80211_orig/sys/wlc_mac80211.c brcm80211/sys/wlc_mac80211.c
--- brcm80211_orig/sys/wlc_mac80211.c	2010-10-12 04:18:07.940125220 -0400
+++ brcm80211/sys/wlc_mac80211.c	2010-10-12 04:19:19.814961117 -0400
@@ -2783,7 +2783,7 @@ int BCMINITFN(wlc_up) (wlc_info_t *wlc)
 
 	if (wlc->pub->radio_disabled) {
 		wlc_radio_monitor_start(wlc);
-		return 0;
+		return BCME_RADIOOFF;
 	}
 
 	/* wlc_bmac_up_prep has done wlc_corereset(). so clk is on, set it */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/