[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7A94256FD72B884D9E7C55586C3CBCEE1382808041@SJEXCHCCR01.corp.ad.broadcom.com>
Date: Tue, 12 Oct 2010 11:34:30 -0700
From: "Brett Rudley" <brudley@...adcom.com>
To: "jcm@...masters.org" <jcm@...masters.org>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
cc: "Henry Ptasinski" <henryp@...adcom.com>,
"Nohee Ko" <noheek@...adcom.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] [staging] brcm80211: fix radio disabled on attempt
to bring up interface
Signed-off-by: Brett Rudley <brudley@...adcom.com>
---
> -----Original Message-----
> From: jcm@...masters.org [mailto:jcm@...masters.org]
> Sent: Tuesday, October 12, 2010 1:30 AM
> To: linux-wireless@...r.kernel.org
> Cc: Brett Rudley; Henry Ptasinski; Nohee Ko; Jon Masters; LKML
> Subject: [PATCH] [staging] brcm80211: fix radio disabled on attempt to
> bring up interface
>
> The brcm80211 driver does not correctly handle the case that the wireless
> radio hardware is physically disabled during interface initialization. An
> attempt is made to check whether the radio is disabled, and in the case
> that it is, a background worker is setup to monitor for the radio coming
> online, but the interface queues are incorrectly brought up anyway. The
> value BCME_RADIOOFF should be returned in wlc_up in such error case.
>
> Signed-off-by: Jon Masters <jcm@...masters.org>
>
> diff -urNp brcm80211_orig/sys/wlc_mac80211.c brcm80211/sys/wlc_mac80211.c
> --- brcm80211_orig/sys/wlc_mac80211.c 2010-10-12 04:18:07.940125220 -
> 0400
> +++ brcm80211/sys/wlc_mac80211.c 2010-10-12 04:19:19.814961117 -0400
> @@ -2783,7 +2783,7 @@ int BCMINITFN(wlc_up) (wlc_info_t *wlc)
>
> if (wlc->pub->radio_disabled) {
> wlc_radio_monitor_start(wlc);
> - return 0;
> + return BCME_RADIOOFF;
> }
>
> /* wlc_bmac_up_prep has done wlc_corereset(). so clk is on, set it
> */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists