linux-kernel - Re: [PATCH] serial: omap-serial: fix signess error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8739sb1cif.fsf@deeprootsystems.com>
Date:	Tue, 12 Oct 2010 11:39:36 -0700
From:	Kevin Hilman <khilman@...prootsystems.com>
To:	Vasiliy Kulikov <segooon@...il.com>,
	Tony Lindgren <tony@...mide.com>
Cc:	kernel-janitors@...r.kernel.org,
	"Govindraj.R" <govindraj.raja@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error

[adding linux-omap list]

Vasiliy Kulikov <segooon@...il.com> writes:

> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
>
> Signed-off-by: Vasiliy Kulikov <segooon@...il.com>
> ---
>  I cannot compile this driver, so it is not tested.

Acked-by: Kevin Hilman <khilman@...prootsystems.com>

Since the original driver is being queued via the omap tree, we can
queue this one as well.

Tony, can you add this one to the 2.6.37 queue?

Thanks,

Kevin

>  drivers/serial/omap-serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
> index 2ee1d32..14365f7 100644
> --- a/drivers/serial/omap-serial.c
> +++ b/drivers/serial/omap-serial.c
> @@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no)
>  {
>  	struct uart_omap_port *up = ui[uart_no];
>  	unsigned int curr_dma_pos, curr_transmitted_size;
> -	unsigned int ret = 0;
> +	int ret = 0;
>  
>  	curr_dma_pos = omap_get_dma_dst_pos(up->uart_dma.rx_dma_channel);
>  	if ((curr_dma_pos == up->uart_dma.prev_rx_dma_pos) ||
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/