linux-kernel - Re: [PATCH unfinished update] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tkrat.b190ad8b687a549a@s5r6.in-berlin.de>
Date:	Wed, 13 Oct 2010 00:25:13 +0200 (CEST)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
cc:	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH unfinished update] firewire: sbp2: parallelize
 login/inquiry, reconnect, and shutdown

> So I changed the patch to the simple one below, but suddenly my
> INIC-2430 device has trouble with inquiry in parallel to its two LUNs:

The following modification fixes this mostly, i.e. always when the first
Inquiry attempt to one LUN fails but succeeds on the other.  But I had
one occasion just now at which both failed; then that reschedule does
simply lead into the same situation until retry limit.

> Maybe I need ordered per-target workqueues.

No, I actually need per-node ordering.  This device, like my other one
and apparently most ones on the market actually keep their SCSI logical
units in separate FireWire units.  Currently firewire-sbp2 is not aware
that fw_unit instances reside on the same node.

This is going to be tougher than I hoped.  Maybe I need a driver-global
Inquiry mutex.  Or move the __scsi_add_device() out of sbp2_login() into
another work which is scheduled to a "single-threaded" workqueue.

--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewire/sbp2.c
@@ -982,6 +982,8 @@ static void sbp2_login(struct work_struc
 	 * lu->work already.  Reset the work from reconnect to login.
 	 */
 	PREPARE_DELAYED_WORK(&lu->work, sbp2_login);
+	if (lu->retries++ < 5)
+		sbp2_queue_work(lu, DIV_ROUND_UP(HZ, 5));
  out:
 	sbp2_target_put(tgt);
 }
@@ -1656,7 +1658,8 @@ MODULE_ALIAS("sbp2");

 static int __init sbp2_init(void)
 {
-	sbp2_wq = create_singlethread_workqueue(KBUILD_MODNAME);
+	sbp2_wq = alloc_workqueue(KBUILD_MODNAME,
+				  WQ_NON_REENTRANT | WQ_RESCUER, 0);
 	if (!sbp2_wq)
 		return -ENOMEM;

-- 
Stefan Richter
-=====-==-=- =-=- -==-=
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/