linux-kernel - Re: [PATCH] ASoC: Add max98088 CODEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101013082414.GD6424@rakim.wolfsonmicro.main>
Date:	Wed, 13 Oct 2010 09:24:14 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Peter Hsiang <Peter.Hsiang@...im-ic.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Marroquin <Jesse.Marroquin@...im-ic.com>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver

On Tue, Oct 12, 2010 at 06:47:52PM -0700, Joe Perches wrote:
> On Tue, 2010-10-12 at 18:20 -0700, Peter Hsiang wrote:

> > +static struct {
> > +       int readable;
> > +       int writable;
> > +       int vol;
> > +} max98088_access[M98088_REG_CNT] = {

> bool instead?

> static struct {
> 	bool readable;
> 	bool writable,
> 	bool vol;
> } etc...

The readable and writable fields are being used as bitmasks:

| +       { 0x1F, 0x1F, 1 }, /* 03 battery voltage */

so this discards data which we may wish to use in future.

> readable isn't used anywhere, writeable is used as bool
> vol isn't a good name as it's easy to confuse with
> volume.  Maybe volatile_register?

vol is traditionally used for this throughout the subsystem.  It's
unfortuante that volatile is a keyword.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/