linux-kernel - Re: [PATCH] ASoC: Add max98088 CODEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101013103224.GK6424@rakim.wolfsonmicro.main>
Date:	Wed, 13 Oct 2010 11:32:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Peter Hsiang <Peter.Hsiang@...im-ic.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Marroquin <Jesse.Marroquin@...im-ic.com>
Subject: Re: [PATCH] ASoC: Add max98088 CODEC driver

On Tue, Oct 12, 2010 at 06:20:10PM -0700, Peter Hsiang wrote:

This looks pretty good, waiting for Liam's review but I think we can do
further stuff incrementally.  Minor comments:

> +
> +       /* Setup an array of texts for the equalizer enum.
> +        * This is based on Mark Brown's equalizer driver code.
> +        * It has been extended to support multiple equalizers.
> +        */

The code that you're basing this on supports multiple equalizers too -
things like the WM8994 have several.  Given that all those supported by
the original code are identical there didn't seem to be any point in
restricting which EQ a given setup can be deployed on - it's just one
more thing that can go wrong.

> +static int max98088_remove(struct snd_soc_codec *codec)
> +{
> +       if (codec->control_data)
> +               max98088_set_bias_level(codec, SND_SOC_BIAS_OFF);

The control_data check should be redundant here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/