linux-kernel - Re: [PATCH] sound/soc: rename vol to volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Oct 2010 13:33:01 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Peter Hsiang <Peter.Hsiang@...im-ic.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Marroquin <Jesse.Marroquin@...im-ic.com>
Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as
 appropriate

On Wed, Oct 13, 2010 at 05:10:45AM -0700, Joe Perches wrote:
> Rename the declaration and uses of variables
> named vol to volatile_register to avoid name
> clash with the much more common use of vol
> for volume.

Are any of the contexts actually ambiguous?  I have to say I don't find
this useful.  If the register I/O code knows anything about volumes I'd
say we've probably messed up somewhere.

> > > static struct {
> > > 	bool readable;
> > > 	bool writable,
> > > 	bool vol;
> > > } etc...

> > The readable and writable fields are being used as bitmasks:

> No, they are being declared as bitmasks.
> writable is used once as bool, readable isn't used at all.

They're being used in the table initialisation.

> > | +       { 0x1F, 0x1F, 1 }, /* 03 battery voltage */

> > so this discards data which we may wish to use in future.

> It's not used as bitmask now, what use would there
> be in the future for it as a bitmask?

Examples would include validating I/O operations done by drivers, or
supporting fancy cache handling that pays attention to things per bit.

> > vol is traditionally used for this throughout the subsystem.  It's
> > unfortuante that volatile is a keyword.

> As far as I see, your description of vol being
> used throughout the subsystem is not true.

I'm sorry?  It's used as the field name for volatility in all the
drivers I can remember that use a table to look volatility up in
register properties.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/