linux-kernel - Re: [PATCH] sound/soc: rename vol to volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286974549.1117.254.camel@Joe-Laptop>
Date:	Wed, 13 Oct 2010 05:55:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Peter Hsiang <Peter.Hsiang@...im-ic.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Marroquin <Jesse.Marroquin@...im-ic.com>
Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as
 appropriate

On Wed, 2010-10-13 at 13:33 +0100, Mark Brown wrote:
> On Wed, Oct 13, 2010 at 05:10:45AM -0700, Joe Perches wrote:
> > Rename the declaration and uses of variables
> > named vol to volatile_register to avoid name
> > clash with the much more common use of vol
> > for volume.
> Are any of the contexts actually ambiguous?  I have to say I don't find
> this useful.  If the register I/O code knows anything about volumes I'd
> say we've probably messed up somewhere.

Looking at the 2 register access routines where
volatile_register/vol is used, I'd say those
routines aren't useful at all and the checks
should be inline instead.

This sort of wrapper routine doesn't serve
much of a purpose to me:

 static int wm8904_volatile_register(unsigned int reg)
 {
-       return wm8904_access[reg].vol;
+       return wm8904_access[reg].volatile_register;
 }

> It's used as the field name for volatility in all the
> drivers I can remember that use a table to look volatility up in
> register properties.

I did a grep for vol in sound, I found the uses
where it was for volatile and patched them.

Are there others?  Perhaps, but I don't think so.
Probably not in sound.  Was there some other
subsystem you meant?  Maybe you have examples
I missed?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/