linux-kernel - Re: [PATCH] sound/soc: rename vol to volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286983667.1117.347.camel@Joe-Laptop>
Date:	Wed, 13 Oct 2010 08:27:47 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Peter Hsiang <Peter.Hsiang@...im-ic.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Peter Ujfalusi <peter.ujfalusi@...ia.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jesse Marroquin <Jesse.Marroquin@...im-ic.com>
Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as
 appropriate

On Wed, 2010-10-13 at 16:11 +0100, Mark Brown wrote:
> On Wed, Oct 13, 2010 at 05:55:48AM -0700, Joe Perches wrote:
> > Looking at the 2 register access routines where
> > volatile_register/vol is used, I'd say those
> > routines aren't useful at all and the checks
> > should be inline instead.
> If you check the code again you will notice that these functons are all
> used in ops structures which presents obvious issues when trying to
> replace with open coded checks.
> I hope their usefulness is clear given the above.

There is some value in using consistent
function styles for table driven and non-table
driven instances.

> > > It's used as the field name for volatility in all the
> > > drivers I can remember that use a table to look volatility up in
> > > register properties.
> > I did a grep for vol in sound, I found the uses
> > where it was for volatile and patched them.
> You're missing the "for this" here, I believe.  To reiterate what I said
> originally as far as I can remember every ASoC driver which uses a table
> to look up volatility uses this naming.

So all in this case means 3, 1 of which
doesn't use it.  I sent patches for them.

The last patch saves ~3kb which I think
is useful for ASoC.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/