linux-kernel - RE: linux-next: Tree for October 13 (staging/iio)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Oct 2010 20:07:19 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	driverdevel <devel@...verdev.osuosl.org>
CC:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"gregkh@...e.de" <gregkh@...e.de>,
	Jonathan Cameron <jic23@....ac.uk>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Drivers <Drivers@...log.com>
Subject: RE: linux-next: Tree for October 13 (staging/iio)

Randy Dunlap wrote on 2010-10-13:
> On Wed, 13 Oct 2010 15:45:22 +1100 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20101012:
>
>
> drivers/staging/iio/adc/ad7476.h:62: note: expected 'struct device *'
> but argument is of type 'struct ad7476_state *'
> drivers/staging/iio/adc/ad7476_core.c:48: error: too few arguments to
> function 'ad7476_scan_from_ring'

Thanks!

That's due to an old prototype active when CONFIG_IIO_RING_BUFFER is not set.
I'll fix that.

> drivers/staging/iio/adc/ad7476_core.c: At top level:
> drivers/staging/iio/adc/ad7476_core.c:102: error:
> 'IIO_SCAN_EL_TYPE_UNSIGNED' undeclared here (not in a function)

Jonathan,

Do we really need to guard the entire ring_generic.h header with

#ifdef CONFIG_IIO_RING_BUFFER
...

Some of these might be used, even when CONFIG_IIO_RING_BUFFER is not set.
Or do we really need CONFIG_IIO_RING_BUFFER at all.
Why not always provide it?

>
> config is attached.
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your
> code ***

Greetings,
Michael

Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/