linux-kernel - RE: [PATCH 3/4] iovmm: replace __iounmap with omap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Oct 2010 03:18:30 -0500
From:	"Guzman Lugo, Fernando" <fernando.lugo@...com>
To:	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
CC:	"felipe.contreras@...ia.com" <felipe.contreras@...ia.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: RE: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap


> ________________________________________
> From: Hiroshi DOYU [Hiroshi.DOYU@...ia.com]
> Sent: Thursday, October 14, 2010 1:45 AM
> To: Guzman Lugo, Fernando
> Cc: felipe.contreras@...ia.com; tony@...mide.com;
>  linux-kernel@...r.kernel.org; andy.shevchenko@...il.com; linux-omap@...r.kernel.org
> Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
> 
> Hi Fernando,
> 
> From: ext Fernando Guzman Lugo <x0095840@...com>
> Subject: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
> Date: Thu, 14 Oct 2010 04:27:36 +0200
> 
> > Omap platform is omap_iounmap function.
> >
> > Signed-off-by: Fernando Guzman Lugo <x0095840@...com>
> > ---
> >  arch/arm/plat-omap/iovmm.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
> > index 93a34d9..5489ca9 100644
> > --- a/arch/arm/plat-omap/iovmm.c
> > +++ b/arch/arm/plat-omap/iovmm.c
> > @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da)
> >       struct sg_table *sgt;
> >       typedef void (*func_t)(const void *);
> >
> > -     sgt = unmap_vm_area(obj, da, (func_t)__iounmap,
> 
> +       sgt = unmap_vm_area(obj, da, (func_t)iounmap,
> 
> Woundn't the above be enough?
> 
> Eventually this "iounmap()" calls "__arch_iounmap()" ->
> "omap_iounmap()". I don't see any special reason to call
> "omap_iounmap()" here for now.

iounmap and __arch_iounmap are macros they cannot not
be used there. If so, it gives a "undeclared" compile error.

Regards,
Fernando.

> 
> 
> > +     sgt = unmap_vm_area(obj, da, (func_t)omap_iounmap,
> >                           IOVMF_LINEAR | IOVMF_MMIO);
> >       if (!sgt)
> >               dev_dbg(obj->dev, "%s: No sgt\n", __func__);
> > --
> > 1.6.3.3
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/