linux-kernel - Re: [PATCH -next] mmc: fix cb710 kconfig dependency warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101014090442.GA14454@rere.qmqm.pl>
Date:	Thu, 14 Oct 2010 11:04:42 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, Chris Ball <cjb@...top.org>,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH -next] mmc: fix cb710 kconfig dependency warning

On Wed, Oct 13, 2010 at 06:15:19PM -0700, Randy Dunlap wrote:
> Fix kconfig dependency warning to satisfy dependencies:
> 
> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: <mirq-linux@...e.qmqm.pl>
> ---
>  drivers/mmc/host/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -394,7 +394,7 @@ config MMC_TMIO
>  
>  config MMC_CB710
>  	tristate "ENE CB710 MMC/SD Interface support"
> -	depends on PCI
> +	depends on PCI && MISC_DEVICES
>  	select CB710_CORE
>  	help
>  	  This option enables support for MMC/SD part of ENE CB710/720 Flash

Is this really necessary? MISC_DEVICES is only a submenu enabler, not
a real dependency.

Maybe just select MISC_DEVICES instead? User/developer should not have
to know that for this specific MMC controller he has to first enable some
other device burried somewhere in the config tree.

Best Regards,
Michał Mirosław

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/