linux-kernel - Re: [PATCH] Serial: BUGFIX: uart_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Oct 2010 21:45:57 +0200
From:	Stanislav Brabec <sbrabec@...e.cz>
To:	Greg KH <greg@...ah.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
	Alan Cox <alan@...ux.intel.com>, Arnd Bergmann <arnd@...db.de>,
	Andr Goddard Rosa <andre.goddard@...il.com>,
	Jason Wang <jason77.wang@...il.com>,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] Serial: BUGFIX: uart_resume_port has an omitted
 condition.

Greg KH wrote: 
> > This disparity appeared deliberately in 4547be78. If you need
> > no_console_suspend and the hardware lets the device in an undefined
> > state after resume (i. e. PXA270), you need to call subset of the
> > resume, even if the suspend counterpart was not called. Yes, I can
> > imagine that it may be a source of problems.
 
> > It seems that support for no_console_suspend for all devices is becoming
> > more complicated. I guess that a new driver calls (maybe "save_state"
> > and "resume_state") or support for no_console_suspend directly in
> > drivers may be useful.
> 
> Ok, so I'm guessing that this patch is not to be applied then, correct?

I just compared it with Jason Wang's patches. MyungJoo Ham's patch is
exactly equal to the PATCH 1/2. So it already has my ACK and it is
pending as:

serial-core: skip call set_termios/console_start when no_console_suspend

Related thread can be found in linux-serial archives from August 2010:
[PATCH RESEND 0/2] two serial_core suspend/resume fixes

To MyungJoo Ham: Could you verify, that Jason Wang's patch 2/2 does not
break your system? My patch to fix PXA270 does not exist yet. I'll ask
you in future for testing.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@...e.cz
Lihovarská 1060/12           tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/