linux-kernel - Re: [patch] x86: allow ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Oct 2010 13:40:37 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
CC:	Pekka Enberg <penberg@...nel.org>,
	David Rientjes <rientjes@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Casey Dahlin <cdahlin@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [patch] x86: allow ZONE_DMA to be configurable

I don't like the CONFIG_EXPERT prefix, just because it makes it hard to move things into and out of this rubric, and that's bad... (consider: "oh, that would mean this *huge* patch) ... not to mention that what is CONFIG_EXPERT on one platform may not be for another!  As far as the main switch is concerned, it's a better name of course...

"Andrew Morton" <akpm@...ux-foundation.org> wrote:

>On Thu, 14 Oct 2010 20:34:48 +0200
>Ingo Molnar <mingo@...e.hu> wrote:
>
>> 
>> * H. Peter Anvin <hpa@...or.com> wrote:
>> 
>> > On 10/14/2010 09:00 AM, Pekka Enberg wrote:
>> >
>> > >> CONFIG_EMBEDDED *is* "I am a user who (think I) know what I'm 
>> > >> doing". That is *what it is* and *all it is*.
>> > > 
>> > > Yup. The naming is quite unfortunate, though. Can we change it to 
>> > > something else?
>> > 
>> > Funny, this seems to come up repeatedly ;)
>> 
>> I'd suggest to rename CONFIG_EMBEDDED=y to CONFIG_EXPERT=y, but i'd also 
>> suggest to rename all sub-config-options that depend on CONFIG_EXPERT to 
>> have a CONFIG_EXPERT_ prefix.
>> 
>> So we'd have:
>> 
>>   CONFIG_EXPERT_CPU_SUP_INTEL=y
>>   CONFIG_EXPERT_MMAP_ALLOW_UNINITIALIZED=y
>> 
>> etc.
>
>yup.  CONFIG_EMBEDDED didn't make a lot of sense even when we first did it. 
>I suppose CONFIG_EXPERT is OK, although everyone will select it because
>they think they're experts ;)  CONFIG_PROPELLORHEAD!
>
>> That way all the enabled 'expert options' become easily visible in the 
>> .config file and they advertise themselves properly - it's also easily 
>> greppable. In the source code it also becomes self-documenting, it's 
>> obvious when a dependency is 'rare' or 'special' - it has a 
>> CONFIG_EXPERT_ prefix.
>> 
>> Something for the KS i guess.
>
>nah, just do it.

-- 
Sent from my mobile phone.  Please pardon any lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/