linux-kernel - Re: Process to push changes to include/linux/types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201010151215.49392.agruen@suse.de>
Date:	Fri, 15 Oct 2010 12:15:49 +0200
From:	Andreas Gruenbacher <agruen@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, davem@...emloft.net
Subject: Re: Process to push changes to include/linux/types.h

On Friday 15 October 2010 11:01:34 Andrew Morton wrote:
> On Fri, 15 Oct 2010 10:22:49 +0200 Andi Kleen <andi@...stfloor.org> wrote:
> 
> > Jan Engelhardt <jengelh@...ozas.de> writes:
> > 
> > > I would be interested in knowing whether you - in whichever subsystems
> > > you happen to be active - would even need aligned_u64. Right now,
> > > the only users seem to be PPP and scsi_tgt besides Netfilter.
> > 
> > Using aligned_u64 is good practice to avoid problems with the 
> > 32bit/64bit compat layer. I would recommend it to anyone 
> > adding a new user space interface passing a 64bit value.
> > 
> 
> What "problems" does it prevent when used for this?

64-bit values align to 4-byte boundaries on some 32-bit architectures like x86 
and to 8-byte boundaries on 64-bit architetures.  The new __aligned_64 type 
enforces 8-byte alignment and so structs containing __aligned_64 values have 
the same alignment on 32-bit and 64-bit architectures.  No conversions are 
necessary between 32-bit user-space and a 64-bit kernel.

Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/