linux-kernel - Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101015192645.GA2438@tuxdriver.com>
Date:	Fri, 15 Oct 2010 15:26:46 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Christian Lamparter <chunkeey@...glemail.com>
Cc:	Tejun Heo <tj@...nel.org>,
	Johannes Berg <johannes@...solutions.net>,
	Linux Wireless List <linux-wireless@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly
 instead of depending on flush_scheduled_work()

On Fri, Oct 15, 2010 at 06:58:44PM +0200, Christian Lamparter wrote:
> On Friday 15 October 2010 18:39:37 Tejun Heo wrote:
> > Hello,
> 
> > >> -    /*
> > >> -     * For key todo, it'll be empty by now but the work
> > >> -     * might still be scheduled.
> > >> -     */
> > >> -    flush_scheduled_work();
> > > 
> > > oops, todo work no longer exists...
> > > 
> > > Anyway, ACK.
> > 
> > Are you going to route this through wireless tree?  Shall I repost
> > with update patch description?
> 
> wireless-testing/wireless-next has already such a patch:
> "mac80211: cancel restart_work in ieee80211_unregister_hw" (2010-08-25)
> 
> <http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=258086a48b766d12a500f98834654ffa927ca475>
> 
> John, can you please push to 2.6.36-rc8?
> (I know, I am _late_, but I didn't know about any potential problem
> in the mainline?)

I don't see how either patch would merit inclusion in 2.6.36 at this point.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/