linux-kernel - Re: [PATCH 8/9] jump label: Make arch_jump_label_text_poke

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB8C61A.2050008@caviumnetworks.com>
Date:	Fri, 15 Oct 2010 14:22:34 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jason Baron <jbaron@...hat.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 8/9] jump label: Make arch_jump_label_text_poke_early()
 optional

On 10/15/2010 02:08 PM, Steven Rostedt wrote:
> On Fri, 2010-10-15 at 23:06 +0200, Peter Zijlstra wrote:
>> On Fri, 2010-10-15 at 16:09 -0400, Steven Rostedt wrote:
>>> +
>>> +#ifdef HAVE_ARCH_JUMP_LABEL_TEXT_POKE_EARLY
>>>   extern void arch_jump_label_text_poke_early(jump_label_t addr);
>>> +#else
>>> +static inline void arch_jump_label_text_poke_early(jump_label_t addr) {}
>>> +#endif
>>> +
>>
>> How often is this called, do we really need to avoid that call? It looks
>> like init code.
>
> Yeah, that's a good point.
>
> What's the harm in doing a stub in the mips code here?
>

Really the SPARC code (and any architectures added in the future with a 
well defined optimal NOP) should be doing nothing here as well.

So I could turn the question around and ask:  How many empty definitions 
of this thing do you want in the tree?

I will defer to Steven.  If he wants to push the empty stubs into all 
the architectures, I will update the MIPS patch and he can remove/revert 
the 'jump label: Make arch_jump_label_text_poke_early() optional' patch.

Let me know which option you would prefer.

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/