linux-kernel - Re: [PATCH 1/4] m32r: restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Oct 2010 02:41:58 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	takata@...ux-m32r.org, linux-m32r@...linux-m32r.org
Subject: Re: [PATCH 1/4] m32r: restore _BLOCKABLE

On Fri, Oct 15, 2010 at 09:16:45PM -0400, Kyle McMartin wrote:
> Commit a7f8388e accidentally removed it...
> 
> Signed-off-by: Kyle McMartin <kyle@...hat.com>
> ---
>  arch/m32r/kernel/signal.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/m32r/kernel/signal.c b/arch/m32r/kernel/signal.c
> index 7bbe386..cc36fe1 100644
> --- a/arch/m32r/kernel/signal.c
> +++ b/arch/m32r/kernel/signal.c
> @@ -28,6 +28,8 @@
>  
>  #define DEBUG_SIG 0
>  
> +#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
> +

Grrr...   Sorry, reordering breakage.  In the signals tree here I have

static inline void sig_set_blocked(struct sigset_t *set)
{
        sigdelsetmask(set, sigmask(SIGKILL) | sigmask(SIGSTOP));
        spin_lock_irq(&current->sighand->siglock);
        current->blocked = *set;
        recalc_sigpending();
        spin_unlock_irq(&current->sighand->siglock);
}

and it's used all over the place (including quite a few places where
we currently have sigprocmask(SIG_SETMASK, set, NULL), which is what
it's equivalent to).  With that done, m32r doesn't use _BLOCKABLE
anywhere, so it got removed.  And that chunk got picked when I'd been
reordering the queue to pull the arch-specific fixes in front.  Sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/