linux-kernel - Re: [PATCH 2/4] m32r: get_user takes an lvalue, not a pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101016014430.GS19804@ZenIV.linux.org.uk>
Date:	Sat, 16 Oct 2010 02:44:30 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Kyle McMartin <kyle@...artin.ca>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	takata@...ux-m32r.org, linux-m32r@...linux-m32r.org
Subject: Re: [PATCH 2/4] m32r: get_user takes an lvalue, not a pointer

On Fri, Oct 15, 2010 at 09:17:09PM -0400, Kyle McMartin wrote:
>  static int prev_insn(struct pt_regs *regs)
>  {
>  	u16 inst;
> -	if (get_user(&inst, (u16 __user *)(regs->bpc - 2)))
> +	if (get_user(inst, (u16 __user *)(regs->bpc - 2)))

Ouch...  ACKed, my fuckup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/