linux-kernel - Re: [PATCH 0/6] Results of my work on memorystick subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287410779.20229.9.camel@maxim-laptop>
Date:	Mon, 18 Oct 2010 16:06:19 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/6] Results of my work on memorystick subsystem

On Mon, 2010-10-18 at 00:05 -0700, Alex Dubov wrote:
> --- On Sun, 17/10/10, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> 
> > > 
> > > Here is a result of lot of work I did improving the
> > memorystick
> > > subsystem and its drivers.
> > Comments?
> > Flames?
> > Suggestions?
> > 
> 
> My opinion is, that in the current form your patches are completely
> unworkable.
> 
> I suggest a following approach, consisting of 3 clearly separated steps:
> 
> Step 1 - a set of functional patches to jmicron driver.
> Step 2 - a set of functional patches to mspro driver.
> Step 3 - common code elimination (the whole thing is not that large, it
> can tolerate some code duplication).
> 
> When we done with this, we can discuss whatever cosmetic changes you want
> to do (moving stuff around and , possibly, renaming, which I don't see as
> necessary at all).
Alex,
In jmicron driver I did move functions around and renamed them.
I am not against doing that in separate patch.

But for mspro driver, it would be really hard for me to split it.
I have rewritten a lot of code there.
Can't we just review the end result instead of the patch?

To split the patches, I pretty much need to rewrite the whole thing once
gain.
I don't want to do that.

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/