linux-kernel - Re: [PATCH] checkpatch: allow single space before labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101018143935.GA4120@thunk.org>
Date:	Mon, 18 Oct 2010 10:39:35 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Joe Perches <joe@...ches.com>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels

On Sun, Oct 17, 2010 at 04:26:25PM -0400, Mike Frysinger wrote:
> On Sun, Oct 17, 2010 at 16:01, Peter Zijlstra wrote:
> > On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote:
> >> sounds like a good reason to shut up the new unintended warnings
> >
> > I'm failing to see any logic there, old code doesn't generate warnings,
> > its new code that would, and new code should never have any whitespace
> > in front of labels.
> 
> it's a waste of time to massage code to one person's opinion

+1

It's not in CondingStyle; I prefer to outdent labels by one tab stop:

			if (!page_has_buffers(page)) {
				if (block_prepare_write(page, 0, len,
						noalloc_get_block_write)) {
				redirty_page:
					redirty_page_for_writepage(mpd->wbc,
								   page);
					unlock_page(page);
					continue;
				}
				commit_write = 1;
			}

... and I hereby serve notice that if I start getting trash patches
from newbies about checkpatch.pl warning/errors for stuff like this,
I'll will (a) toast them and tell them they are wasting their time
with checkpatch.pl, and (b) agitate strongly for the removal of such
trash checkpatch.pl or for checkpatch.pl as a whole, as being harmful
to kernel development.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/