| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101018145400.GD4120@thunk.org> Date: Mon, 18 Oct 2010 10:54:00 -0400 From: Ted Ts'o <tytso@....edu> To: Mike Frysinger <vapier@...too.org>, Peter Zijlstra <peterz@...radead.org>, Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] checkpatch: allow single space before labels On Mon, Oct 18, 2010 at 10:39:35AM -0400, Ted Ts'o wrote: > On Sun, Oct 17, 2010 at 04:26:25PM -0400, Mike Frysinger wrote: > > On Sun, Oct 17, 2010 at 16:01, Peter Zijlstra wrote: > > > On Sun, 2010-10-17 at 15:49 -0400, Mike Frysinger wrote: > > >> sounds like a good reason to shut up the new unintended warnings > > > > > > I'm failing to see any logic there, old code doesn't generate warnings, > > > its new code that would, and new code should never have any whitespace > > > in front of labels. > > > > it's a waste of time to massage code to one person's opinion > > +1 > > It's not in CondingStyle; I prefer to outdent labels by one tab stop: Note that there is absolutely nothing about how labels should be indented in CodingStyle at all, and I very much resist code straightjackets being imposed by checkpatch.pl implementors. Can we please stop this nonsense? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists