linux-kernel - Re: [PATCH] checkpatch: allow single space before labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287413933.29097.1608.camel@twins>
Date:	Mon, 18 Oct 2010 16:58:53 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ted Ts'o <tytso@....edu>
Cc:	Mike Frysinger <vapier@...too.org>, Joe Perches <joe@...ches.com>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: allow single space before labels

On Mon, 2010-10-18 at 10:54 -0400, Ted Ts'o wrote:
> Note that there is absolutely nothing about how labels should be
> indented in CodingStyle at all, and I very much resist code
> straightjackets being imposed by checkpatch.pl implementors.
> 
> Can we please stop this nonsense? 

1) ignoring checkpatch over taste is good
2) by 1) its impossible to get checkpatch right
3) therefore pure checkpatch patches are nonsense

So can we agree that checkpatch is ok in its current form, and we should
simply administer physical violence towards checkpatch wankers?

PS. I frequently practise 2).
PPS. I find your preferred label indenting truly hideous.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/