lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2010 11:29:52 +0200 From: Peter Zijlstra <peterz@...radead.org> To: Mike Galbraith <efault@....de> Cc: LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [RFC/RFT PATCH] sched: automated per tty task groups On Tue, 2010-10-19 at 11:16 +0200, Mike Galbraith wrote: > + read_lock_irqsave(&tasklist_lock, flags); > + > + rcu_read_lock(); > + for_each_process(p) { > + tg = task_group(p); > + tty_sched_move_task(p, tg); > + list_for_each_entry_rcu(t, &p->thread_group, thread_group) { > + tty_sched_move_task(t, tg); > + } > + } > + rcu_read_unlock(); > + > + read_unlock_irqrestore(&tasklist_lock, flags); I don't think you need to disable IRQs for tasklist lock, nor do I think you actually need it. If you enable tty groups and then scan all the existing tasks you've covered them all, new tasks will already be placed right, dying tasks we don't care about anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists