linux-kernel - Re: [PATCH 2/2] mfd: Add WM831x SPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101019095347.GC11371@opensource.wolfsonmicro.com>
Date:	Tue, 19 Oct 2010 02:53:54 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: Add WM831x SPI support

On Tue, Oct 19, 2010 at 11:44:23AM +0200, Samuel Ortiz wrote:

> > +static int wm831x_spi_write_device(struct wm831x *wm831x, unsigned short reg,
> > +				   int bytes, void *src)
> > +{
> > +	struct spi_device *spi = wm831x->control_data;
> > +	u16 *s = src;
> > +	u16 data[2];
> > +	int ret;
> > +
> > +	/* Go register at a time */
> > +	for (r = reg; r < reg + (bytes / 2); r++) {
> > +		data[0] = r;

Oh, gah.  We need an extra int r here, I've obviously stuffed up the
move from the BSP I was working on.  Sorry about that:

>From b7fc0d8ff8c96fabf531d685bda7c3d5b8c51f35 Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Date: Tue, 19 Oct 2010 02:53:08 -0700
Subject: [PATCH] mfd: Fix missing variable in WM831x SPI

Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
---
 drivers/mfd/wm831x-spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
index 073d4c6..2789b15 100644
--- a/drivers/mfd/wm831x-spi.c
+++ b/drivers/mfd/wm831x-spi.c
@@ -48,7 +48,7 @@ static int wm831x_spi_write_device(struct wm831x *wm831x, unsigned short reg,
 	struct spi_device *spi = wm831x->control_data;
 	u16 *s = src;
 	u16 data[2];
-	int ret;
+	int ret, r;
 
 	/* Go register at a time */
 	for (r = reg; r < reg + (bytes / 2); r++) {
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/