linux-kernel - Re: [PATCH 2/2] mfd: Add WM831x SPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101019105232.GN2736@sortiz-mobl>
Date:	Tue, 19 Oct 2010 12:52:32 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] mfd: Add WM831x SPI support

Hi Mark,

On Tue, Oct 19, 2010 at 02:53:54AM -0700, Mark Brown wrote:
> On Tue, Oct 19, 2010 at 11:44:23AM +0200, Samuel Ortiz wrote:
> 
> > > +static int wm831x_spi_write_device(struct wm831x *wm831x, unsigned short reg,
> > > +				   int bytes, void *src)
> > > +{
> > > +	struct spi_device *spi = wm831x->control_data;
> > > +	u16 *s = src;
> > > +	u16 data[2];
> > > +	int ret;
> > > +
> > > +	/* Go register at a time */
> > > +	for (r = reg; r < reg + (bytes / 2); r++) {
> > > +		data[0] = r;
> 
> Oh, gah.  We need an extra int r here, I've obviously stuffed up the
> move from the BSP I was working on.  Sorry about that:
No problem, I didn't see it as I haven't build my tree yet.
I squashed this fix into the initial patch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/