linux-kernel - [PATCH] sched_rt: Removes extra checking for nr_cpus_allowed when calling find_lowest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinoaJX3M2zU_zZOpmFm9Ekxpw-LUVUf_TU8yuSq@mail.gmail.com>
Date:	Tue, 19 Oct 2010 16:57:39 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>
Subject: [PATCH] sched_rt: Removes extra checking for nr_cpus_allowed when
 calling find_lowest_rq

 sched_rt: Removes extra checking for nr_cpus_allowed when calling
find_lowest_rq

Remove the check for nr_cpus_allowed of an RT task before calling
find_lowest_cpu() from select_task_rq_rt function. Cause
find_lowest_cpu checks for rt.nr_cpus_allowed of a process.
It would've been nice, if we make the check before calling
find_lowest_cpu. But its called from other places, so keep the
nr_cpus_allowed check into find_lowest_cpu().


Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
---

--- linus-rc8/kernel/sched_rt.c	2010-10-15 05:26:43.000000000 +0600
+++ rakib-rc8/kernel/sched_rt.c	2010-10-19 16:22:30.000000000 +0600
@@ -971,8 +971,7 @@ select_task_rq_rt(struct rq *rq, struct
 	 * that is just being woken and probably will have
 	 * cold cache anyway.
 	 */
-	if (unlikely(rt_task(rq->curr)) &&
-	    (p->rt.nr_cpus_allowed > 1)) {
+	if (unlikely(rt_task(rq->curr))) {
 		int cpu = find_lowest_rq(p);

 		return (cpu == -1) ? task_cpu(p) : cpu;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/