linux-kernel - Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinXzMQXoyyu+anSCvSuE9w3FWAP5HswDS0kfpzE@mail.gmail.com>
Date:	Tue, 19 Oct 2010 13:59:58 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	balbi@...com
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

On Tue, Oct 19, 2010 at 1:32 PM, Felipe Balbi <balbi@...com> wrote:
> On Tue, Oct 19, 2010 at 05:03:28AM -0500, Felipe Contreras wrote:
>>
>> +       depends on (NOP_USB_XCEIV || TWL4030_USB)
>> +       default y if ARCH_OMAP3
>> +       default y if ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN
>
> it could be only me, but I see these kind of dependencies tend to
> disaster. They can all grow to infinity. Soon, we will have another twl
> family of devices, or we will have another MACH_* which will need
> nop_xceiv, etc etc.

The USB_MUSB_HDRC dependency on NOP_USB_XCEIV || TWL4030_USB is
already there, I'm just making it explicit. The rest are not
dependencies, just sensible defaults, and they are already in
drivers/usb/musb/Kconfig, I'm just moving them.

If you have a better approach to avoid manually selecting TWL4030_USB
on defconfigs, and making sure USB_MUSB_HDRC works, please share it.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/