| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101019203913.GA2322@vigoh> Date: Tue, 19 Oct 2010 18:39:13 -0200 From: "Gustavo F. Padovan" <padovan@...fusion.mobi> To: pavan_savoy@...com Cc: marcel@...tmann.org, linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3] Bluetooth: btwilink driver * pavan_savoy@...com <pavan_savoy@...com> [2010-10-19 16:57:38 -0400]: > From: Pavan Savoy <pavan_savoy@...com> > > v3 comments > > Marcel, Gustavo, & list, > Please review this version of patch. > > Anderson, > I have taken care of most of the comments you had. > Have re-wrote some of the code commenting you've mentioned. > Thanks for the comments, > > The other few like -EPERM for platform driver registration is to keep > it similar to other drivers Which drivers returns -EPERM to any kind of error? The are many reasons why the funcion can fail, and you want to give the best error report to the user. Use EPERM to all of them is just wrong. >type casting is maintained just to feel safe > and have style similar to other drivers. We don't need to feel safe here. Type cast actually can hide errors, only use them when you really need to cast, in many case here you don't. -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists