linux-kernel - RE: [PATCH v3] Bluetooth: btwilink driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19F8576C6E063C45BE387C64729E739404AA4E790D@dbde02.ent.ti.com>
Date:	Wed, 20 Oct 2010 02:15:29 +0530
From:	"Savoy, Pavan" <pavan_savoy@...com>
To:	"Gustavo F. Padovan" <padovan@...fusion.mobi>
CC:	"marcel@...tmann.org" <marcel@...tmann.org>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] Bluetooth: btwilink driver




> -----Original Message-----
> From: Gustavo F. Padovan [mailto:pao@...fusion.mobi] On Behalf Of Gustavo F.
> Padovan
> Sent: Tuesday, October 19, 2010 3:39 PM
> To: Savoy, Pavan
> Cc: marcel@...tmann.org; linux-bluetooth@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v3] Bluetooth: btwilink driver
> 
> * pavan_savoy@...com <pavan_savoy@...com> [2010-10-19 16:57:38 -0400]:
> 
> > From: Pavan Savoy <pavan_savoy@...com>
> >
> > v3 comments
> >
> > Marcel, Gustavo, & list,
> > Please review this version of patch.
> >
> > Anderson,
> > I have taken care of most of the comments you had.
> > Have re-wrote some of the code commenting you've mentioned.
> > Thanks for the comments,
> >
> > The other few like -EPERM for platform driver registration is to keep
> > it similar to other drivers
> 
> Which drivers returns -EPERM to any kind of error? The are many reasons
> why the funcion can fail, and you want to give the best error report to the
> user. Use EPERM to all of them is just wrong.

Yes, it can fail for plenty of reasons.
So I'll just return whatever I get from platform_driver_register.
Is this OK?


> >type casting is maintained just to feel safe
> > and have style similar to other drivers.
> 
> We don't need to feel safe here. Type cast actually can hide errors,
> only use them when you really need to cast, in many case here you don't.

Ok, I can remove type casting.
I am not really for or against it...

> --
> Gustavo F. Padovan
> ProFUSION embedded systems - http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/