linux-kernel - Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101020175420.GC3431@legolas.emea.dhcp.ti.com>
Date:	Wed, 20 Oct 2010 20:54:20 +0300
From:	Felipe Balbi <balbi@...com>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	"Balbi, Felipe" <balbi@...com>,
	Roger Quadros <roger.quadros@...ia.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-main <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

Hi,

On Wed, Oct 20, 2010 at 11:22:17AM -0500, Felipe Contreras wrote:
>Users would not need to care... if they enable USB and USB_GADGET, it
>will be selected automatically for OMAP3, which is what users would
>expect.

wouldn't a user expect USB to be enabled if the board _has_ a USB
connector ?

>I was talking more about developers.
>
>How should the help be fixed?
>"Select y if you are using an OMAP3 system that has TWL4030"

If you have the TWL4030 family of PMIC chips and want to use USB, you
probably need this. If unsure, say Y.

>1) Do you think all the OMAP3 boards should add that?

why not ?

>2) What if you don't want to use USB?

what if you don't want to use USB and we use your choice of:

default y if ARCH_OMAP3 ??

what's the big difference ? The default will be "USB enabled" and if you
don't want, just drop it. The thing is that in most cases we want to
support what is wired on the board. RX51 has a USB micro-B connector, so
by default we want USB peripheral enabled and host disabled. If a user
(or developer for that matter) wants to play with the unsupported host
mode on RX51, he will enable that part by himself and pray for it to
work. If, on the other hand, a camera developer doesn't need USB at all
and decides to save a few bytes on the binary, he will make sure to
disable it.

The thing is that there's no way to make everybody happy, so we stick to
what the board is wired to do.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/