linux-kernel - RE: [PATCH 1/1] power: bq24617: Adding initial charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E88A1D35AF5437468E5B14C7C4BA61C702D37CA98C@HQMAIL01.nvidia.com>
Date:	Wed, 20 Oct 2010 10:52:08 -0700
From:	Rhyland Klein <rklein@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"cboutatmailru@...il.com" <cboutatmailru@...il.com>,
	Andrew Chew <AChew@...dia.com>,
	"olof@...om.net" <olof@...om.net>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] power: bq24617: Adding initial charger support

> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: Tuesday, October 19, 2010 8:03 PM
> To: Rhyland Klein
> Cc: cboutatmailru@...il.com; Andrew Chew; olof@...om.net; linux-
> tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 1/1] power: bq24617: Adding initial charger support
> 
> On Tue, Oct 19, 2010 at 07:17:11PM -0700, rklein@...dia.com wrote:
> > From: Rhyland Klein <rklein@...dia.com>
> >
> > Initial checkin adding basic support for the TI BQ24617 battery charger
> on the
> > Nvidia Tegra architecture.
> 
> Why is this driver dependant on the CPU?  I can't see anything in the
> code that makes it so.

In hindsight this isn't the most accurate statement. The driver itself is not dependent on the CPU, it is dependent on the platform design, and in particular requires the PG line to be piped in through a GPIO. Would it make more sense to make the driver dependent on GPIO instead?

> 
> > +	if (old_status != -1 &&
> > +		old_status != new_status) {
> > +		dev_dbg(&chip->pdev->dev,
> > +			"%s: %i -> %i\n", __func__, old_status,
> > +			new_status);
> > +		kobject_uevent(&chip->power_supply.dev->kobj, KOBJ_CHANGE);
> 
> power_supply_changed().

Alright.

> 
> > +static irqreturn_t bq24617_irq_switch(int irq, void *devid)
> > +{
> > +	struct bq24617_info *chip = devid;
> > +
> > +	schedule_work(&chip->ac_work);
> > +
> > +	return IRQ_HANDLED;
> > +}
> 
> You're looking for a threaded IRQ handler here - use
> request_threaded_irq() with no primary handler.

Alright I will look into this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/