linux-kernel - Re: [PATCH 1/1] power: bq24617: Adding initial charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101020030235.GA25392@sirena.org.uk>
Date:	Wed, 20 Oct 2010 04:02:35 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	rklein@...dia.com
Cc:	cboutatmailru@...il.com, achew@...dia.com, olof@...om.net,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] power: bq24617: Adding initial charger support

On Tue, Oct 19, 2010 at 07:17:11PM -0700, rklein@...dia.com wrote:
> From: Rhyland Klein <rklein@...dia.com>
> 
> Initial checkin adding basic support for the TI BQ24617 battery charger on the
> Nvidia Tegra architecture.

Why is this driver dependant on the CPU?  I can't see anything in the
code that makes it so.

> +	if (old_status != -1 &&
> +		old_status != new_status) {
> +		dev_dbg(&chip->pdev->dev,
> +			"%s: %i -> %i\n", __func__, old_status,
> +			new_status);
> +		kobject_uevent(&chip->power_supply.dev->kobj, KOBJ_CHANGE);

power_supply_changed().

> +static irqreturn_t bq24617_irq_switch(int irq, void *devid)
> +{
> +	struct bq24617_info *chip = devid;
> +
> +	schedule_work(&chip->ac_work);
> +
> +	return IRQ_HANDLED;
> +}

You're looking for a threaded IRQ handler here - use
request_threaded_irq() with no primary handler.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/