linux-kernel - Re: [PATCH] drivers/hwmon: Use pr_fmt and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101020213810.6b31c04e@endymion.delvare>
Date:	Wed, 20 Oct 2010 21:38:10 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	dave@....org
Cc:	Joe Perches <joe@...ches.com>,
	Guenter Roeck <guenter.roeck@...csson.com>,
	Hans de Goede <j.w.r.degoede@....nl>,
	Alistair John Strachan <alistair@...zero.co.uk>,
	Henrik Rydberg <rydberg@...omail.se>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Luca Tettamanti <kronos.it@...il.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Juerg Haefliger <juergh@...il.com>,
	Eric Piel <eric.piel@...mplin-utc.net>,
	Jim Cromie <jim.cromie@...il.com>,
	Roger Lucas <vt8231@...denengine.co.uk>,
	lm-sensors@...sensors.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>

On Wed, 20 Oct 2010 16:19:46 -0300, Davidlohr Bueso wrote:
> On Wed, 2010-10-20 at 09:42 +0200, Jean Delvare wrote:
> > Hi Joe,
> > 
> > On Tue, 19 Oct 2010 16:13:40 -0700, Joe Perches wrote:
> > > Convert printks to pr_<level>
> > > Coalesce long formats
> > > Removed prefixes from formats
> > > Added #define pr_fmt KBUILD_MODNAME ": " fmt
> > > Standardized abitguru messages for reporting and finding MAINTAINER
> > > (...)
> > > diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
> > > index 03694cc..8f07a9d 100644
> > > --- a/drivers/hwmon/abituguru.c
> > > +++ b/drivers/hwmon/abituguru.c
> > > @@ -20,6 +20,9 @@
> > >      the custom Abit uGuru chip found on Abit uGuru motherboards. Note: because
> > >      of lack of specs the CPU/RAM voltage & frequency control is not supported!
> > >  */
> > > +
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > +
> > >  #include <linux/module.h>
> > 
> > It looks odd that every driver would have to set this. Shouldn't this
> > be the default set in <linux/kernel.h>? Something like:
> > 
> > #ifndef pr_fmt
> > #ifdef KBUILD_MODNAME
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > #else
> > #define pr_fmt(fmt) fmt
> > #endif /* KBUILD_MODNAME */
> > #endif
> > 
> 
> Well we do have this:
> #ifndef pr_fmt
> #define pr_fmt(fmt) fmt
> #endif

I can read the code, thank you. My point is that what we have is
insufficient, as Joe is proposing to use a different pr_fmt definition
for pretty much all drivers in the kernel tree.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/