linux-kernel - Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimJQN=SNCDwOJLo0MKXEcutTKZ3qd81hNAKeXGg@mail.gmail.com>
Date:	Fri, 22 Oct 2010 13:31:28 +0100
From:	Richard Hughes <hughsient@...il.com>
To:	Sitsofe Wheeler <sitsofe@...oo.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Len Brown <lenb@...nel.org>, Zhang Rui <rui.zhang@...el.com>,
	David Zeuthen <davidz@...hat.com>,
	Richard Hughes <richard@...hsie.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown values in get_property()

On 21 October 2010 17:54, Sitsofe Wheeler <sitsofe@...oo.com> wrote:
> I guess there are a whole bunch of other attributes that could
> theoretically be -1 and shouldn't be used if they return it...

I think checking for <0 is probably a good idea, and I'm a little
surprised we don't do this already. Patch welcome, if this is what you
decide to do.

Richard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/