[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 22 Oct 2010 22:23:15 +0100
From: Jack Stone <jwjstone@...tmail.fm>
To: Ben Hutchings <ben@...adent.org.uk>
CC: Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
stable@...nel.org, Florian Fainelli <florian@...nwrt.org>,
stable-review@...nel.org, torvalds@...ux-foundation.org,
akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
600155@...s.debian.org, Jason Heeris <jason.heeris@...il.com>,
David Miller <davem@...emloft.net>, spamalot@...peed.ch
Subject: Re: [11/17] r6040: Fix multicast list iteration when hash filter
is used
On 22/10/2010 22:18, Ben Hutchings wrote:
> On Fri, 2010-10-22 at 20:29 +0100, Jack Stone wrote:
>> On 22/10/2010 20:23, Greg KH wrote:
>>> On Fri, Oct 22, 2010 at 08:13:27PM +0100, Jack Stone wrote:
>>>> On 22/10/2010 19:39, Greg KH wrote:
>>>>> drivers/net/r6040.c | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> --- a/drivers/net/r6040.c
>>>>> +++ b/drivers/net/r6040.c
>>>>> @@ -976,6 +976,7 @@ static void r6040_multicast_list(struct
>>>>> iowrite16(hash_table[3], ioaddr + MAR3);
>>>>> }
>>>>> /* Multicast Address 1~4 case */
>>>>> + dmi = dev->mc_list;
>>>>> for (i = 0, dmi; (i < dev->mc_count) && (i < MCAST_MAX); i++) {
>>>> Any reason for the dmi in the above line? As far as I can see it is a
>>>> nop.
>>>
>>> Look closer at the for loop please.
>>
>> Maybe I'm missing something but:
>> for (i = 0, ---->dmi <----; (i < ...
>>
>> The dmi here still doesn't seem to do anything?
>
> It doesn't, but it doesn't do any harm either. The loop has been
> rewritten in mainline.
Agreed, it causes no problems, but it seems like it was intended to be
the dmi init, i.e.
for (i = 0, dmi = dev->mc_list; ...
I suppose it doesn't really matter but either removing the dmi in the
for loop or moving the dmi init in there would make more sense to me.
I really should learn to explain myself fully. Sorry for taking up
your time.
Thanks,
Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists