linux-kernel - Re: [11/17] r6040: Fix multicast list iteration when hash filter is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287782286.20865.248.camel@localhost>
Date:	Fri, 22 Oct 2010 22:18:06 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Florian Fainelli <florian@...nwrt.org>,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	600155@...s.debian.org, Jason Heeris <jason.heeris@...il.com>,
	David Miller <davem@...emloft.net>, spamalot@...peed.ch
Subject: Re: [11/17] r6040: Fix multicast list iteration when hash filter
 is used

On Fri, 2010-10-22 at 20:29 +0100, Jack Stone wrote:
> On 22/10/2010 20:23, Greg KH wrote:
> > On Fri, Oct 22, 2010 at 08:13:27PM +0100, Jack Stone wrote:
> >> On 22/10/2010 19:39, Greg KH wrote:
> >>>  drivers/net/r6040.c |    1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> --- a/drivers/net/r6040.c
> >>> +++ b/drivers/net/r6040.c
> >>> @@ -976,6 +976,7 @@ static void r6040_multicast_list(struct
> >>>  		iowrite16(hash_table[3], ioaddr + MAR3);
> >>>  	}
> >>>  	/* Multicast Address 1~4 case */
> >>> +	dmi = dev->mc_list;
> >>>  	for (i = 0, dmi; (i < dev->mc_count) && (i < MCAST_MAX); i++) {
> >> Any reason for the dmi in the above line? As far as I can see it is a
> >> nop.
> > 
> > Look closer at the for loop please.
> 
> Maybe I'm missing something but:
> for (i = 0, ---->dmi <----; (i < ...
> 
> The dmi here still doesn't seem to do anything?

It doesn't, but it doesn't do any harm either.  The loop has been
rewritten in mainline.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)