linux-kernel - [PATCH update] firewire: nosy: char device is not seekable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tkrat.f853df65a5128ca0@s5r6.in-berlin.de>
Date:	Sat, 23 Oct 2010 01:08:57 +0200 (CEST)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Arnd Bergmann <arnd@...db.de>
cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [PATCH update] firewire: nosy: char device is not seekable

Remove unnecessary .llseek handler that came in via an automated mass conversion.
.llseek = NULL means no_llseek since commit 776c163b1b93.

The only client that uses this interface is nosy-dump in linux/tools/firewire
and it knows not to seek in this char dev.

Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
---
I left out the addition of return nonseekable_open(...) in nosy_open in
this update.  This works for nosy, but is it also formally correct?

 drivers/firewire/nosy.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c
index bf184fb..8528b10 100644
--- a/drivers/firewire/nosy.c
+++ b/drivers/firewire/nosy.c
@@ -405,7 +405,6 @@ static const struct file_operations nosy_ops = {
 	.poll =			nosy_poll,
 	.open =			nosy_open,
 	.release =		nosy_release,
-	.llseek =		noop_llseek,
 };
 
 #define PHY_PACKET_SIZE 12 /* 1 payload, 1 inverse, 1 ack = 3 quadlets */
-- 
Stefan Richter
-=====-==-=- =-=- =-===
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/