linux-kernel - Re: [PATCH update] firewire: nosy: char device is not seekable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201010231057.18135.arnd@arndb.de>
Date:	Sat, 23 Oct 2010 10:57:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH update] firewire: nosy: char device is not seekable

On Saturday 23 October 2010, Stefan Richter wrote:
> Remove unnecessary .llseek handler that came in via an automated mass conversion.
> .llseek = NULL means no_llseek since commit 776c163b1b93.
> 
> The only client that uses this interface is nosy-dump in linux/tools/firewire
> and it knows not to seek in this char dev.
> 
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> ---
> I left out the addition of return nonseekable_open(...) in nosy_open in
> this update.  This works for nosy, but is it also formally correct?
> 

Most likely you also want the nonseekeable_open, which would prevent
both llseek and pread/pwrite, whereas leaving out llseek currently
only prevents llseek.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/