| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 23 Oct 2010 22:29:53 +0200 From: Johan Hovold <jhovold@...il.com> To: Greg KH <gregkh@...e.de> Cc: Alon Ziv <alon+git@...aviz.org>, linux-usb@...r.kernel.org, Stefani Seibold <stefani@...bold.net>, Jason Wessel <jason.wessel@...driver.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] Export usb_serial_generic_write_room for use in other modules On Sat, Oct 23, 2010 at 09:37:47AM -0700, Greg KH wrote: > On Sat, Oct 23, 2010 at 06:20:17PM +0200, Alon Ziv wrote: > > Any module using usb_serial_generic_write (which is already exported) > > had better use usb_serial_generic_write_room as well. > > Are you implying that the one driver using this function today is > broken? Care to provide a patch for it as well? Actually, most usb serial drivers use usb_serial_generic_write as well as usb_serial_generic_write_room. The generic implementations are used unless drivers explicitly define their own. So far there has been no need to export usb_serial_generic_write_room but perhaps Alon's patch does require this. Either way the patch description is thus actually wrong (or rather misleading) as it stands. I'll try to have a look at the other patch tomorrow. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists