linux-kernel - Re: [PATCH 1/2] Export usb_serial_generic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4CC3159E.3030500@nolaviz.org>
Date:	Sat, 23 Oct 2010 19:04:30 +0200
From:	Alon Ziv <alon@...aviz.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Alon Ziv <alon+git@...aviz.org>, linux-usb@...r.kernel.org,
	Johan Hovold <jhovold@...il.com>,
	Stefani Seibold <stefani@...bold.net>,
	Jason Wessel <jason.wessel@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Export usb_serial_generic_write_room for use in	other
 modules

On 10/23/2010 06:37 PM, Greg KH wrote:
> On Sat, Oct 23, 2010 at 06:20:17PM +0200, Alon Ziv wrote:
>   
>> Any module using usb_serial_generic_write (which is already exported)
>> had better use usb_serial_generic_write_room as well.
>>     
> Are you implying that the one driver using this function today is
> broken?  Care to provide a patch for it as well?
>
>   
Well...
The one driver using it now is usb_debug, which only supports BREAK
signaling.
The generic code does not invoke the write_room callback before invoking
break_ctl, so there is no way to use this function in usb_serial.

At worst, with the current code, usb_serial's break_ctl may become a
no-op if
another BREAK signal is outstanding--which should not be an issue (assuming
regular serial protocol semantics, that is, "BREAK" has indeterminate
length).

-a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/