linux-kernel - Re: [PATCHv6 1/3] ARM: imx: Add gpio-keys to plat-mxc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Oct 2010 11:50:49 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Eric Bénard <eric@...rea.com>
Cc:	Dinh.Nguyen@...escale.com, linux-kernel@...r.kernel.org,
	amit.kucheria@...onical.com, linux@....linux.org.uk,
	s.hauer@...gutronix.de, grant.likely@...retlab.ca,
	linux-arm-kernel@...ts.infradead.org, daniel@...aq.de,
	valentin.longchamp@...l.ch
Subject: Re: [PATCHv6 1/3] ARM: imx: Add gpio-keys to plat-mxc

Hello Eric,

On Sat, Oct 23, 2010 at 10:06:21AM +0200, Eric Bénard wrote:
> Le 23/10/2010 04:46, Dinh.Nguyen@...escale.com a écrit :
>> +struct platform_device *__init imx_add_gpio_keys(
>> +		const struct gpio_keys_platform_data *pdata)
>> +{
>> +	return imx_add_platform_device("gpio-keys", -1, NULL,
>> +		 0, pdata, sizeof(*pdata));
>> +}
>
> What is the added value of this ?
Is is (more or less) in line with the other imx functions that
dynamically add platform devices.

> gpio-keys is not i.MX specific so why should that land in plat-mxc ?
I consider it OK for now.  I know Eric does/wants something similar for
pxa.  If you want to push forward unification here that's great, but
IMHO this is nothing that should stop this patch which is a good step
forward.

BTW another low hanging fruit is to use use
platform_device_register_resndata to implement imx_add_platform_device
and add a few additional checks, like warn if CONFIG_DEBUG_SOMETHING is
enabled and data is non-NULL and doesn't point to .init-memory.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/