linux-kernel - Re: [077/103] KVM: x86: Fix SVM VMCB reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC2B033.7020806@msgid.tls.msk.ru>
Date:	Sat, 23 Oct 2010 13:51:47 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Greg KH <gregkh@...e.de>
CC:	linux-kernel@...r.kernel.org, stable@...nel.org, greg@...ah.com,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Zachary Amsden <zamsden@...hat.com>, mtosatti@...hat.com,
	avi@...hat.com
Subject: Re: [077/103] KVM: x86: Fix SVM VMCB reset

22.10.2010 22:51, Greg KH wrote:
> 2.6.35-stable review patch.  If anyone has any objections, please let us know.
> ------------------
> 
> From: Marcelo Tosatti <mtosatti@...hat.com>
> 
> commit 58877679fd393d3ef71aa383031ac7817561463d upstream.
> 
> On reset, VMCB TSC should be set to zero.  Instead, code was setting
> tsc_offset to zero, which passes through the underlying TSC.

Not an objection, but shouldn't this and subsequent 078 "KVM: x86: Move
TSC reset out of vmcb_init" patches be applied to 2.6.32 too?  The same
problem exists in 2.6.32, and the two patches allows an smp linux guest
to boot in there, or such a guest just hangs at boot.  (078 patch needs
to be adjusted a bit for 2.6.32, since the code there is a bit different
and it does not apply correctly; but the change is trivial).

Thanks!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/