linux-kernel - Re: OOPs on loop module removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CC4920A.5050100@kernel.dk>
Date:	Sun, 24 Oct 2010 22:07:38 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Milan Broz <mbroz@...hat.com>
CC:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: OOPs on loop module removal

On 2010-10-24 21:14, Milan Broz wrote:
> 
> 
> Hi,
> Simple modprobe loop ; rmmod loop
> on Linus' tree now produces now OOPS.
> 
> Bisected to patch (and reverting fixes problem)
> 
> commit 7681bfeeccff5efa9eb29bf09249a3c400b15327
> Author: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
> Date:   Tue Oct 19 09:05:00 2010 +0200
> 
>     block: fix accounting bug on cross partition merges
> 
> The problem is probably that patch uses directly q->queue_lock
> even if queue is being destroyed (QUEUE_FLAG_DEAD is set).
> See what loop (and not only this code) does:
> 
>         blk_cleanup_queue(lo->lo_queue);
> 	put_disk(lo->lo_disk);

Yep that commit was not the most fortunate one. I will send out a revert
now, which will gives us time to fix this for real without rushing
things.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/