linux-kernel - Re: [GIT PULL] Revert of the IO stat fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin-xocNea5k2m+P2a9XGfyoOf_0ZN=kj0fxm8Pg@mail.gmail.com>
Date:	Sun, 24 Oct 2010 13:53:41 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [GIT PULL] Revert of the IO stat fix

On Sun, Oct 24, 2010 at 1:44 PM, Jens Axboe <jaxboe@...ionio.com> wrote:
>>
>> The patch itself is sound, the problems are around the area of it not
>> really liking non-elevator devices with the elv_quiesce_start/end()
>> parts. I had the below patch for that, but then I could not decide
>> whether we were fully safe on queue free after talking to Vivek about
>> it.
>
> Forgot to include it, here it is. I'll be offline from now and 1-2 days
> forward.

Hmm. I actually like this patch more than the revert. Except that I
think the __elv_quiesce_start/end() functions should be static, and
not exposed in the header file. There don't seem to be any other files
that would want to use them anyway, and the whole change looks very
sane since all the outside users used to have to take the lock
explicitly (and thus moving it inside the elv_quiesce_start/end
functions seems to be a nice cleanup).

So if this patch is supposed to fix things and doesn't have any
*known* problems, but you're just not entirely sure about it and we're
talking just a few days of you being gone, I'd almost rather take the
risk. If worst comes to worst, I can revert both this patch and the
original one. We _are_ in the middle of the merge window after all, so
I'm much more open to risks than I would be later in the -rc series..

                                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/