linux-kernel - Re: [PATCH 03/29] memstick: core: add new functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <117301.25688.qm@web37608.mail.mud.yahoo.com>
Date:	Mon, 25 Oct 2010 07:56:10 -0700 (PDT)
From:	Alex Dubov <oakad@...oo.com>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Maxim Levitsky <maximlevitsky@...il.com>
Subject: Re: [PATCH 03/29] memstick: core: add new functions

--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@...il.com> wrote:

> From: Maxim Levitsky <maximlevitsky@...il.com>
> Subject: [PATCH 03/29] memstick: core: add new functions
> To: "Alex Dubov" <oakad@...oo.com>
> Cc: "Andrew Morton" <akpm@...ux-foundation.org>, "LKML" <linux-kernel@...r.kernel.org>, "Maxim Levitsky" <maximlevitsky@...il.com>
> Received: Friday, 22 October, 2010, 4:53 PM
> Add a lot of support code that will
> be used later.
> 

You're adding here a lot of temporarily dead code, which, while being
useful, should be better added together with the actual driver
functionality.

Besides this, the patch has a lot of unneeded clean-ups which are better
be set as a separate patch.

And it doesn't conform to the coding guideline either (4 byte indents,
instead of tabs).



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/